On Thu, Feb 26, 2026 at 06:50:23PM +0800, fanhuang wrote:
> +
> + if (addr < x86ms->below_4g_mem_size) {
> + if (addr + node_size <= x86ms->below_4g_mem_size) {
> + guest_addr = addr;
> + } else {
> + error_report("NUMA node %d with memmap-type spans across
> "
> + "4GB boundary, not supported", i);
> + exit(EXIT_FAILURE);
> + }
> + } else {
> + guest_addr = 0x100000000ULL +
> + (addr - x86ms->below_4g_mem_size);
> + }
> +
I missed this on my first go around
Should this be:
guest_addr = x86ms->above_4g_mem_start +
(addr - x86ms->below_4g_mem_size);
Or is there a reason for the hard-code?
~Gregory
