> On 6. Mar 2026, at 16:58, Mohamed Mediouni <[email protected]> wrote:
> 
> 
> 
>> On 6. Mar 2026, at 16:56, Peter Maydell <[email protected]> wrote:
>> 
>> On Fri, 6 Mar 2026 at 15:53, Mohamed Mediouni <[email protected]> 
>> wrote:
>>> 
>>> 
>>> 
>>> On 6. Mar 2026, at 16:44, Peter Maydell <[email protected]> wrote:
>>> 
>>> On Fri, 6 Mar 2026 at 14:58, Peter Maydell <[email protected]> wrote:
>>> 
>>> 
>>> On Fri, 6 Mar 2026 at 13:01, Mohamed Mediouni <[email protected]> 
>>> wrote:
>>> 
>>> 
>>> Link to branch: https://github.com/mediouni-m/qemu hvf-irqchip-and-nested
>>> (tag for this submission: hvf-irqchip-and-nested-v15)
>>> 
>>> This series adds supports for nested virtualisation when using HVF on arm64 
>>> Macs.
>>> 
>>> Reviews would be very welcome :-) It's maybe a bit unlikely that this will 
>>> make
>>> it to QEMU 11.0 I might as well try.
>>> 
>>> The first two patches are from the SME enablement series and are present 
>>> for the
>>> series to be buildable on its own.
>>> 
>>> 
>>> 
>>> 
>>> Applied to target-arm.next, thanks.
>>> 
>>> 
>>> I'm afraid this failed to build in our gitlab CI job for macos:
>>> 
>>> https://gitlab.com/qemu-project/qemu/-/jobs/13388426185
>>> 
>>> In file included from ../target/arm/hvf/hvf.c:489:
>>> ../target/arm/hvf/sysreg.c.inc:174:21: error: 'HV_SYS_REG_CNTHCTL_EL2'
>>> is only available on macOS 15.0 or newer
>>> [-Werror,-Wunguarded-availability-new]
>>> 174 | DEF_SYSREG_VGIC_EL2(HV_SYS_REG_CNTHCTL_EL2, 3, 4, 14, 1, 0)
>>> | ^
>>> /Applications/Xcode_16.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/System/Library/Frameworks/Hypervisor.framework/Headers/hv_vcpu_types.h:312:5:
>>> note: 'HV_SYS_REG_CNTHCTL_EL2' has been marked as being introduced in
>>> macOS 15.0 here, but the deployment target is macOS 14.0.0
>>> 312 | HV_SYS_REG_CNTHCTL_EL2 API_AVAILABLE(macos(15.0))
>>> API_UNAVAILABLE(ios, tvos) = 0xe708,
>>> | ^
>>> 
>>> and similarly for other registers.
>>> 
>>> I'm going to drop the last 4 patches from the series, which I hope will
>>> fix the CI problems.
>>> 
>>> — PMM
>>> 
>>> Hello,
>>> 
>>> Will submit a new rev of the last 4 patches with a workaround for this then…
>>> 
>>> (Ugh @ compiler pragmas but there aren’t better choices unfortunately)
>> 
>> Unfortunately the problems aren't in just the nested-virt part:
>> 
>> https://gitlab.com/qemu-project/qemu/-/jobs/13389185563
>> 
>> still complains, including about hv_gic_config_create().
>> 
>> I'm going to drop everything except the first 2 patches.
>> 
>> thanks
> 
> Ok, will try to see if I can repro the CI config. My apologies.
> 
> (It all builds locally :( )

Hello,

For future reference what it takes to reproduce this locally is:
export MACOSX_DEPLOYMENT_TARGET=14.0

That showed a bunch of spurious warnings though:

/Users/sunrise/workspaces/qemu/include/qemu/cutils.h:144:12: warning: 
'strchrnul' is only available on macOS 15.4 or newer 
[-Wunguarded-availability-new]
  144 |     return strchrnul(s, c);
      |            ^~~~~~~~~
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/_string.h:198:9:
 note: 'strchrnul' has been marked as being introduced in macOS 15.4 here, but 
the deployment target is macOS 14.0.0
  198 |         strchrnul(const char *__s, int __c);
      |         ^
/Users/sunrise/workspaces/qemu/include/qemu/cutils.h:144:12: note: enclose 
'strchrnul' in a __builtin_available check to silence this warning
  144 |     return strchrnul(s, c);

Sent over a new rev with guarding squashed in as needed (for the vGIC code, 
availability skipped because it’s… whether the GIC is available or not is 
checked in target/arm/hvf/hvf.c, and for target/arm/hvf/hvf.c, checking across 
the board except for EL2/vGIC register availability which are handled via a 
separate mechanism)

Sorry for this :/ should have anticipated it better

>> -- PMM
>> 
> 
> 


Reply via email to