From: Akihiko Odaki <[email protected]>
The file pointer can be NULL when e.g., opening the file failed.
vcpu_interval_exec() already implements a NULL-pointer check, but
plugin_exit() misses it. Handle the condition by adding the missing
check to plugin_exit().
Fixes: 0d279bec0f14 ("contrib/plugins: Add a plugin to generate basic block
vectors")
Signed-off-by: Akihiko Odaki <[email protected]>
Reviewed-by: Pierrick Bouvier <[email protected]>
Reviewed-by: Philippe Mathieu-Daudé <[email protected]>
Link:
https://lore.kernel.org/qemu-devel/[email protected]
Signed-off-by: Pierrick Bouvier <[email protected]>
---
contrib/plugins/bbv.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/contrib/plugins/bbv.c b/contrib/plugins/bbv.c
index b9da6f815e3..5913cc6c637 100644
--- a/contrib/plugins/bbv.c
+++ b/contrib/plugins/bbv.c
@@ -30,8 +30,13 @@ static uint64_t interval = 100000000;
static void plugin_exit(qemu_plugin_id_t id, void *p)
{
+ Vcpu *vcpu;
+
for (int i = 0; i < qemu_plugin_num_vcpus(); i++) {
- fclose(((Vcpu *)qemu_plugin_scoreboard_find(vcpus, i))->file);
+ vcpu = qemu_plugin_scoreboard_find(vcpus, i);
+ if (vcpu->file) {
+ fclose(vcpu->file);
+ }
}
g_hash_table_unref(bbs);
--
2.47.3
