On Mon, 9 Mar 2026, BALATON Zoltan wrote:
On Sun, 8 Mar 2026, Philippe Mathieu-Daudé wrote:
Hi Chad,
On 3/3/26 03:47, Chad Jablonski wrote:
This series implements HOST_DATA as a blit source enabling text rendering
in
xterm under X.org with 2D acceleration.
The series builds up functionality incrementally:
* Patches 1-6: Bug fixes and register implementations
* Patches 7-14: Refactor of ati_2d_blt to decouple from ATIVGAState
* Patch 15: Scissor clipping implementation
* Patches 16-17: HOST_DATA register writes, color expansion, and
accumulator flush
Chad Jablonski (17):
ati-vga: Fix framebuffer mapping by using hardware-correct aperture
sizes
ati-vga: Fix DST_PITCH and SRC_PITCH reads
ati-vga: Read aliased values from DP_GUI_MASTER_CNTL
ati-vga: Latch src and dst pitch and offset on master_cntl default
ati-vga: Implement foreground and background color register writes
ati-vga: Add scissor clipping register support
ati-vga: Remove dst_x/y updates after blit
ati-vga: Consolidate dirty region tracking in ati_2d_blt
ati-vga: Remove src and dst stride mutation in ati_2d_blt
ati-vga: Use local variables for register values in ati_2d_blt
ati-vga: Introduce ATI2DCtx struct for 2D blit context
ati-vga: Extract setup_2d_blt_ctx from ati_2d_blt
ati-vga: Split ati_2d_do_blt from ati_2d_blt
ati-vga: Remove ATIVGAState param from ati_2d_do_blt
ati-vga: Implement scissor rectangle clipping for 2D operations
ati-vga: Implement HOST_DATA register writes
ati-vga: Implement HOST_DATA flush to VRAM
Zoltan asked me to look at your series [*] but unfortunately I'm
getting a build failure when building without PIXMAN starting
with patch #9:
../hw/display/ati_2d.c: In function ‘ati_2d_do_blt’:
../hw/display/ati_2d.c:185:13: error: unused variable ‘src_stride_words’
[-Werror=unused-variable]
185 | int src_stride_words = ctx->src_stride / sizeof(uint32_t);
| ^~~~~~~~~~~~~~~~
../hw/display/ati_2d.c:147:9: error: unused variable ‘dst_stride_words’
[-Werror=unused-variable]
147 | int dst_stride_words = ctx->dst_stride / sizeof(uint32_t);
| ^~~~~~~~~~~~~~~~
../hw/display/ati_2d.c:137:10: error: unused variable ‘use_pixman_blt’
[-Werror=unused-variable]
137 | bool use_pixman_blt = use_pixman & BIT(1);
| ^~~~~~~~~~~~~~
../hw/display/ati_2d.c:136:10: error: unused variable ‘use_pixman_fill’
[-Werror=unused-variable]
136 | bool use_pixman_fill = use_pixman & BIT(0);
| ^~~~~~~~~~~~~~~
I'm queueing the first 8 patches hoping it helps.
Also, please fix the checkpatch.pl coding style errors
before re-posting.
Sorry, my mistake I did not notice this during review and testing. I'm fixing
it up and will send updated version of the last part of the series not yet
queued. Thanks a lot for your help.
I sent updated v12 fixing the above. Before that I've also sent this small
fix independent of this series:
https://patchew.org/QEMU/[email protected]/
Thank you,
BALATON Zoltan
