Nathan Chen <[email protected]> writes:

> From: Nathan Chen <[email protected]>
>
> Introduce a new enum type property allowing to set a Substream ID size
> for HW-accelerated smmuv3. Values are auto and 0..20. The auto value
> allows SSID size property to be derived from host IOMMU capabilities.
> A value of 0 disables SubstreamID, while non-zero values specify the
> SSID size in bits.
>
> Signed-off-by: Nathan Chen <[email protected]>

[...]

> diff --git a/qapi/misc-arm.json b/qapi/misc-arm.json
> index f921d740f1..b372a3661b 100644
> --- a/qapi/misc-arm.json
> +++ b/qapi/misc-arm.json
> @@ -45,3 +45,18 @@
>  #                     { "version": 3, "emulated": false, "kernel": true } ] }
>  ##
>  { 'command': 'query-gic-capabilities', 'returns': ['GICCapability'] }
> +
> +##
> +# @SsidSizeMode:
> +#
> +# SMMUv3 SubstreamID size configuration mode.
> +#
> +# @auto: derive from host IOMMU capabilities
> +#
> +# Values 0-20: SSIDSIZE value in bits.  0 disables SubstreamID.
> +#
> +# Since: 11.0
> +##

This renders like

    Enum SsidSizeMode (Since: 11.0)

       SMMUv3 SubstreamID size configuration mode.

       Values:
          * auto -- derive from host IOMMU capabilities

          * 0 -- Not documented

          * 1 -- Not documented

          * 2 -- Not documented

          * 3 -- Not documented

          * 4 -- Not documented

          * 5 -- Not documented

          * 6 -- Not documented

          * 7 -- Not documented

          * 8 -- Not documented

          * 9 -- Not documented

          * 10 -- Not documented

          * 11 -- Not documented

          * 12 -- Not documented

          * 13 -- Not documented

          * 14 -- Not documented

          * 15 -- Not documented

          * 16 -- Not documented

          * 17 -- Not documented

          * 18 -- Not documented

          * 19 -- Not documented

          * 20 -- Not documented

       Values 0-20: SSIDSIZE value in bits.  0 disables SubstreamID.

Sadly, many existing enums also have undocumented members.  Some because
documenting them one by one would be kind of silly (e.g. QKeyCode).

I don't have a better idea right now, so this is just an observation,
not a demand.  Maybe John Snow (cc'ed) can some day dream up a better
way to do this.

> +{ 'enum': 'SsidSizeMode',
> +  'data': [ 'auto', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9',
> +            '10', '11', '12', '13', '14', '15', '16', '17', '18', '19', '20' 
> ] }
> diff --git a/qapi/pragma.json b/qapi/pragma.json
> index 193bc39059..24aebbe8f5 100644
> --- a/qapi/pragma.json
> +++ b/qapi/pragma.json
> @@ -68,6 +68,7 @@
>          'S390CpuEntitlement',
>          'S390CpuPolarization',
>          'S390CpuState',
> +        'SsidSizeMode',
>          'String',
>          'StringWrapper',
>          'SysEmuTarget',


Reply via email to