On 3/9/26 10:20, Thomas Huth via Devel wrote:
> On 07/03/2026 16.41, Philippe Mathieu-Daudé wrote:
>> The HostMemoryBackend::use_canonical_path boolean
>> was only set in the hw_compat_3_1[] array, via the
>> 'x-use-canonical-path-for-ramblock-id=true' property.
>> We removed all machines using that array, but the
>> comment added in commit 8db0b20415c ("machine: add
>> missing doc for memory-backend option") requested to
>> not remove this property "as long as 4.0 and older
>> machine types exists". Previous commit removed the
>> last machines in this range, we can now remove that
>> property and all the code around it.
>>
>> Signed-off-by: Philippe Mathieu-Daudé <[email protected]>
>> ---
>> qapi/qom.json | 8 +-------
>> include/system/hostmem.h | 2 +-
>> backends/hostmem.c | 34 ----------------------------------
>> qemu-options.hx | 10 ----------
>> 4 files changed, 2 insertions(+), 52 deletions(-)
>>
>> @@ -563,19 +542,6 @@ host_memory_backend_class_init(ObjectClass *oc,
>> const void *data)
>> object_class_property_set_description(oc, "reserve",
>> "Reserve swap space (or huge pages) if applicable");
>> #endif /* CONFIG_LINUX */
>> - /*
>> - * Do not delete/rename option. This option must be considered
>> stable
>> - * (as if it didn't have the 'x-' prefix including deprecation
>> period) as
>> - * long as 4.0 and older machine types exists.
> By the way, this option seems to be used by libvirt - we should maybe
> make sure that its removal does not break libvirt by accident...?
>
> Thomas
>
Thanks Thomas for raising this. Libvirt only sets this to false, it
never set it to true. And we have a code that detects whether this
attribute is present. IIUC false is the default (and after these patches
the behaviour will remain as the same as with 'false' set). So ACK from
libvirt's POV.
Michal
