On Wed, Jun 20, 2012 at 04:16:47PM -0500, Anthony Liguori wrote: [snip] > >diff --git a/qemu-common.h b/qemu-common.h > >index 8f87e41..80026af 100644 > >--- a/qemu-common.h > >+++ b/qemu-common.h > >@@ -264,6 +264,7 @@ typedef struct EventNotifier EventNotifier; > > typedef struct VirtIODevice VirtIODevice; > > typedef struct QEMUSGList QEMUSGList; > > typedef struct SHPCDevice SHPCDevice; > >+typedef struct DMAContext DMAContext; > > Please don't put this in qemu-common.h. Stick it in a dma-specific > header.
I'm pretty sure I started to hit circular include hell without the forward declaration here. -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson