On Wed, 11 Mar 2026 at 10:48, Michael Tokarev <[email protected]> wrote: > > On 08.02.2026 13:39, Sergei Heifetz wrote: > > Hi. This patch series fixes several minor issues reported by our local > > Coverity installation. > > > > Changes in v3: > > - Nothing. I sent the second version of the series without the > > corresponding 'v2' > > suffix by mistake. I apologise. > > > > Changes in v2: > > - Remove assert(block) in system/physmem.c instead of placing it > > before the dereference. > > > > Sergei Heifetz (4): > > migration/savevm.c: reorder usage and assertion of mis->from_src_file > > dump/dump.c: reorder usage and assertion of block > > system/physmem.c: remove useless assertion of block > > hw/usb/core.c: reorder usage and assertion of p->ep > > Hi! > > I applied 3 patches from this series - all but the physmem.c one. > It's ugly either way, so I'm not picking it up. Sigh.
I think patch 3 is good, the commit message just didn't include enough information to fully explain why the assert() there is pointless (i.e. that it's called from only two places, which both already assert or assume that block isn't NULL). thanks -- PMM
