> On 14. Mar 2026, at 22:56, Osama Abdelkader <[email protected]>
> wrote:
>
> IdAa64Mmfr3El1 was stored in idregs[ID_AA64MMFR2_EL1_IDX], overwriting
> MMFR2 and leaving MMFR3 never set. Use ID_AA64MMFR3_EL1_IDX so the host
> MMFR3 value is stored in the correct slot.
>
> Signed-off-by: Osama Abdelkader <[email protected]>
Reviewed-by: Mohamed Mediouni <[email protected]>
Thank you for this one, dunno how I did this typo :/
Will include this one in the next rev of my small patch series.
> ---
> target/arm/whpx/whpx-all.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/arm/whpx/whpx-all.c b/target/arm/whpx/whpx-all.c
> index 513551bec1..98889426d2 100644
> --- a/target/arm/whpx/whpx-all.c
> +++ b/target/arm/whpx/whpx-all.c
> @@ -683,7 +683,7 @@ static bool
> whpx_arm_get_host_cpu_features(ARMHostCPUFeatures *ahcf)
> { WHvArm64RegisterIdAa64Mmfr0El1,
> &ahcf->isar.idregs[ID_AA64MMFR0_EL1_IDX] },
> { WHvArm64RegisterIdAa64Mmfr1El1,
> &ahcf->isar.idregs[ID_AA64MMFR1_EL1_IDX] },
> { WHvArm64RegisterIdAa64Mmfr2El1,
> &ahcf->isar.idregs[ID_AA64MMFR2_EL1_IDX] },
> - { WHvArm64RegisterIdAa64Mmfr3El1,
> &ahcf->isar.idregs[ID_AA64MMFR2_EL1_IDX] }
> + { WHvArm64RegisterIdAa64Mmfr3El1,
> &ahcf->isar.idregs[ID_AA64MMFR3_EL1_IDX] }
> };
>
> int i;
> --
> 2.43.0
>
>
