Coverity reports possible sign extension error (CID 1645615) when reading DEFAULT_SC_BOTTOM_RIGHT register. It cannot happen because the values are limited when writing the register but change the code to match other similar registers and to avoid this warning.
Signed-off-by: BALATON Zoltan <[email protected]> --- hw/display/ati.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/display/ati.c b/hw/display/ati.c index 1a6a5ad4fd..d194f15002 100644 --- a/hw/display/ati.c +++ b/hw/display/ati.c @@ -513,8 +513,8 @@ static uint64_t ati_mm_read(void *opaque, hwaddr addr, unsigned int size) val |= s->regs.default_tile << 16; break; case DEFAULT_SC_BOTTOM_RIGHT: - val = (s->regs.default_sc_bottom << 16) | - s->regs.default_sc_right; + val = s->regs.default_sc_right; + val |= s->regs.default_sc_bottom << 16; break; case SC_TOP: val = s->regs.sc_top; -- 2.41.3
