s/strdup/g_strdup to highlight the issue and be consistent with other allocations.
The next patch is going to introduce vnc_display_free() to take care of deallocating it. Signed-off-by: Marc-André Lureau <[email protected]> --- ui/vnc.h | 2 +- ui/vnc.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/ui/vnc.h b/ui/vnc.h index ec8d0c91b57..c5d678ac31e 100644 --- a/ui/vnc.h +++ b/ui/vnc.h @@ -166,7 +166,7 @@ struct VncDisplay pixman_image_t *server; /* vnc server surface */ int true_width; /* server surface width before rounding up */ - const char *id; + char *id; QTAILQ_ENTRY(VncDisplay) next; char *password; time_t expires; diff --git a/ui/vnc.c b/ui/vnc.c index af5fb3c1551..763b13acbde 100644 --- a/ui/vnc.c +++ b/ui/vnc.c @@ -3430,7 +3430,7 @@ void vnc_display_init(const char *id, Error **errp) } vd = g_malloc0(sizeof(*vd)); - vd->id = strdup(id); + vd->id = g_strdup(id); QTAILQ_INSERT_TAIL(&vnc_displays, vd, next); QTAILQ_INIT(&vd->clients); -- 2.53.0
