This patchset fixes some issues with the fsfreeze-hook guest-agent
script reported in https://gitlab.com/qemu-project/qemu/-/work_items/3339

 * the script is a #!/bin/sh one, but it uses various bash-isms.
   Most are easy fixes, but getting rid of the PIPESTATUS usage
   is a little less obvious, so that gets its own patch
 * a bug in the logic determining whether to log to file or syslog
   means that if the logfile doesn't exist on first run, the script
   will create the logfile but log to syslog (and then log to file
   on second and subsequent runs)

NB: I have tested this by setting up the script and running it
manually in a temp directory, but not as a "real world" fsfreeze.

thanks
-- PMM

Peter Maydell (3):
  scripts/qemu-guest-agent/fsfreeze-hook: Avoid bash-isms
  scripts/qemu-guest-agent/fsfreeze-hook: Avoid use of PIPESTATUS
  scripts/qemu-guest-agent/fsfreeze-hook: Fix syslog-fallback logic

 scripts/qemu-guest-agent/fsfreeze-hook | 34 ++++++++++++++++++--------
 1 file changed, 24 insertions(+), 10 deletions(-)

-- 
2.43.0


Reply via email to