Coverity reports several possible sign extension errors (latest is CID 1645615). These cannot happen because the values are limited when writing the registers and only 32 bits of the return value matter but change type of the variable storing the return value to uint32_t to avoid these warnings. Also change DEFAULT_SC_BOTTOM_RIGHT register read to match what other similar registers do for consistency.
Signed-off-by: BALATON Zoltan <[email protected]> --- Rest of series unchanged so only sending this patch. hw/display/ati.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/display/ati.c b/hw/display/ati.c index 8286f67c1c..705e4db6e4 100644 --- a/hw/display/ati.c +++ b/hw/display/ati.c @@ -266,7 +266,7 @@ static void ati_vga_vblank_irq(void *opaque) ati_vga_update_irq(s); } -static inline uint64_t ati_reg_read_offs(uint32_t reg, int offs, +static inline uint32_t ati_reg_read_offs(uint32_t reg, int offs, unsigned int size) { if (offs == 0 && size == 4) { @@ -279,7 +279,7 @@ static inline uint64_t ati_reg_read_offs(uint32_t reg, int offs, static uint64_t ati_mm_read(void *opaque, hwaddr addr, unsigned int size) { ATIVGAState *s = opaque; - uint64_t val = 0; + uint32_t val = 0; switch (addr) { case MM_INDEX: @@ -514,8 +514,8 @@ static uint64_t ati_mm_read(void *opaque, hwaddr addr, unsigned int size) val |= s->regs.default_tile << 16; break; case DEFAULT_SC_BOTTOM_RIGHT: - val = (s->regs.default_sc_bottom << 16) | - s->regs.default_sc_right; + val = s->regs.default_sc_right; + val |= s->regs.default_sc_bottom << 16; break; case SC_TOP: val = s->regs.sc_top; -- 2.41.3
