On 3/18/26 2:46 AM, Philippe Mathieu-Daudé wrote:
On 18/3/26 09:11, Cédric Le Goater wrote:
On 3/17/26 20:42, Pierrick Bouvier wrote:
Add stubs for needed functions.
--->
As well, we need to add pixman to qemuutil library dependencies since
pixman is transitively included from pci.h header, which is needed to be
able to include prototypes for stubs we declared.
In file included from include/ui/console.h:4,
from ../hw/vfio/vfio-display.h:12,
from ../hw/vfio/pci.h:25,
from ../hw/vfio/igd-stubs.c:9:
include/ui/qemu-pixman.h:10:10: fatal error: pixman.h: No such file or
directory
10 | #include <pixman.h>
| ^~~~~~~~~~
On OpenBSD, opengl headers are not available in default include path,
and thus we need to add opengl to list of qemuutil dependencies.
In file included from /home/root/qemu/include/ui/console.h:9:
/home/root/qemu/include/ui/surface.h:11:11: fatal error: 'epoxy/gl.h'
file not found
Finally,
<---
vfio_pci_hot_reset_info must be forwarded declared on non linux
platforms:
In file included from ../hw/vfio/igd-stubs.c:9:
../hw/vfio/pci.h:265:44: error: 'struct vfio_pci_hot_reset_info'
declared inside parameter list will not be visible outside of this
definition or declaration [-Werror]
265 | struct
vfio_pci_hot_reset_info **info_p);
|
Reviewed-by: Cédric Le Goater <[email protected]>
Reviewed-by: Philippe Mathieu-Daudé <[email protected]>
Signed-off-by: Pierrick Bouvier <[email protected]>
Signed-off-by: Pierrick Bouvier <[email protected]>
Duplicated Signed-off-by. I can fix when applying.
Actually you can also cut description marked betwwen --->
and <--- because already mentioned in future commit 988499515da:
https://lore.kernel.org/qemu-devel/[email protected]/
which removes [*] below (should disappear on rebase).
(Sorry for that hiccups, I was expecting Pierrick series to
be posted after my PR was merged).
No problem, I'll change it and fix the extra signed-off by, so Cedric
can have a clean v5 to apply.
Thanks!
Regards,
Phil.
Thanks,
C.
---
meson.build | 2 +-
hw/vfio/pci.h | 2 ++
hw/vfio/igd-stubs.c | 20 ++++++++++++++++++++
hw/vfio/pci-quirks.c | 5 -----
hw/vfio/meson.build | 1 +
5 files changed, 24 insertions(+), 6 deletions(-)
create mode 100644 hw/vfio/igd-stubs.c
