tcg/aarch64/tcg-target.c.inc contains a lot of numbered instruction formats
called "I3XXX" in the enum AArch64Insn, named for the original section in the
Arm documentation which described those formats.

This patch aims to give them more meaningful names, for example, I3314 becomes
Ildstpair. Where possible, these names match those used in
target/arm/tcg/a64.decode.

For convenience, here is a list of the replacements.

* Automatic changes, made by passing the values in the enum to a modified
  version of the code produced by scripts/decodetree.py:
3206 => branch
3305 => ldlit
3306 => stxp
3312 => ldst_imm
3314 => ldstpair
3401 => addsub_imm
3402 => bitfield_32
3404 => logic_imm_32
3405 => movw_32
3406 => pcrel
3501 => addsub_ext
3502 => addsub_shift
3503 => rrr_sf
3507 => rr_sf
3508 => rrr
3509 => rrrr
3510 => logic_shift
3611 => rrr_e

* Manual changes, still matching names given in a64.decode but found in that
  file manually:
3201 => cbz
3205 => tbz
3207 => bcond_reg
3303 => simd_load_replicate
3403 => extract
3616 => qrrr_e
3617 => qrr_e

* Names invented by me, where a64.decode does not have a meaningful name:
3202 => bcond_imm
3506 => csel
3605 => simd_copy
3606 => simd_imm
3609 => q_shift
3612 => simd_rr
3614 => simd_shift_imm
3502S => addsub_realshift

This is marked RFC partly because there is also a possibility to extract names
from the machine-readable instruction descriptions given by Arm. These would
likely give different names to the ones in a64.decode, which means there is a
good argument for changing the names in a64.decode as well. This requires more
investigation. If we do decide to use Arm's provided instruction format names,
it would likely only change the names used and not the structure of this
change.

Signed-off-by: Jim MacArthur <[email protected]>
---
Jim MacArthur (2):
      tcg/aarch64/tcg-target.c.inc: Replacement of I3XXX names
      tcg/aarch64/tcg-target.c.inc: Manual replace of I3310, I3313

 tcg/aarch64/tcg-target.c.inc | 994 ++++++++++++++++++++++---------------------
 1 file changed, 510 insertions(+), 484 deletions(-)
---
base-commit: 5a68a3add61208aad34d47134fdcfd3f407d2ce4
change-id: 20260319-aarch64-tcg-instruction-format-rename-9a474de54b55

Best regards,
-- 
Jim MacArthur <[email protected]>


Reply via email to