On Sat, 14 Mar 2026 at 22:15, Mohamed Mediouni <[email protected]> wrote: > > Linux uses AccessVpRegs without checking availability and panics if it's not > there. Expose it unconditionally.
The commit message subject says we're enabling enlightenments... > @@ -953,13 +953,15 @@ int whpx_accel_init(AccelState *as, MachineState *ms) > synthetic_features.Bank0.AccessPartitionReferenceTsc = 1; > synthetic_features.Bank0.AccessHypercallRegs = 1; > synthetic_features.Bank0.AccessVpIndex = 1; > - synthetic_features.Bank0.AccessHypercallRegs = 1; ...but the code change seems to be removing one as well as adding the three new ones. Intentional? > synthetic_features.Bank0.TbFlushHypercalls = 1; > synthetic_features.Bank0.AccessSynicRegs = 1; > synthetic_features.Bank0.AccessSyntheticTimerRegs = 1; > synthetic_features.Bank0.AccessIntrCtrlRegs = 1; > synthetic_features.Bank0.SyntheticClusterIpi = 1; > synthetic_features.Bank0.DirectSyntheticTimers = 1; > + synthetic_features.Bank0.FastHypercallOutput = 1; > + synthetic_features.Bank0.AccessVpRegs = 1; > + synthetic_features.Bank0.SyncContext = 1; > > /* > * On ARM64, have enlightenments off by default I've taken this series into target-arm.next for the moment -- I can either drop this patch or else fix it up depending on what the right thing is. PS: for commit messages, could you wrap the body text at the usual 70-ish columns, please? thanks -- PMM
