Prefer the address_space_ld/st API over the legacy ld_phys() because it allow checking for bus access fault. This code however doesn't check for fault, so we simply inline the calls (not specifying any memory transaction attribute nor expecting transation result). No logical change intended.
Signed-off-by: Philippe Mathieu-Daudé <[email protected]> --- target/s390x/kvm/kvm.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/target/s390x/kvm/kvm.c b/target/s390x/kvm/kvm.c index 54d28e37d4d..bd22f6f0188 100644 --- a/target/s390x/kvm/kvm.c +++ b/target/s390x/kvm/kvm.c @@ -36,6 +36,7 @@ #include "qemu/main-loop.h" #include "qemu/mmap-alloc.h" #include "qemu/log.h" +#include "system/memory.h" #include "system/system.h" #include "system/hw_accel.h" #include "system/runstate.h" @@ -1664,13 +1665,16 @@ static void unmanageable_intercept(S390CPU *cpu, S390CrashReason reason, /* try to detect pgm check loops */ static int handle_oper_loop(S390CPU *cpu, struct kvm_run *run) { + const MemTxAttrs attrs = MEMTXATTRS_UNSPECIFIED; CPUState *cs = CPU(cpu); PSW oldpsw, newpsw; - newpsw.mask = ldq_be_phys(cs->as, cpu->env.psa + - offsetof(LowCore, program_new_psw)); - newpsw.addr = ldq_be_phys(cs->as, cpu->env.psa + - offsetof(LowCore, program_new_psw) + 8); + newpsw.mask = address_space_ldq_be(cs->as, cpu->env.psa + + offsetof(LowCore, program_new_psw), + attrs, NULL); + newpsw.addr = address_space_ldq_be(cs->as, cpu->env.psa + + offsetof(LowCore, program_new_psw) + 8, + attrs, NULL); oldpsw.mask = run->psw_mask; oldpsw.addr = run->psw_addr; /* -- 2.53.0
