On 5/6/26 1:41 PM, Thomas Huth wrote: > From: Thomas Huth <[email protected]> > > The elements that get removed with QTAILQ_REMOVE are never referenced > afterwards anymore, so the corresponding memory should get freed. > > Signed-off-by: Thomas Huth <[email protected]> > --- > hw/s390x/s390-pci-bus.c | 1 + > hw/s390x/s390-pci-vfio.c | 1 + > 2 files changed, 2 insertions(+) >
Thanks Thomas! Code looks good and I did some regression testing with this patch applied: Reviewed-by: Matthew Rosato <[email protected]> Tested-by: Matthew Rosato <[email protected]> Should we also consider adding: Fixes: b354d5d804 ("s390x/pci: clean up s390 PCI groups") Fixes: 37fa32de70 ("s390x/pci: Honor DMA limits set by vfio") ? Neither are commonly-driven paths, but s390_pci_end_dma_count can be driven N times via unplug of N vfio-pci devices. Also out of curiosity, did you just stumble on this or was there some tooling or testing that was being employed here that found this? Thanks, Matt
