On 4/28/2026 5:33 PM, Peter Maydell wrote:
From: CJ Chen <[email protected]>
The riscv_iommu_trap_ops MemoryRegionOps specifies that
unaligned accesses are not valid for this device but that
it does implement them. This doesn't make much sense, and
we want to add an assertion that registered MRs don't specify
this invalid combination of settings.
Drop .impl.unaligned = true, with no behaviour change.
Signed-off-by: CJ Chen <[email protected]>
Acked-by: Tomoyuki Hirose <[email protected]>
Reported-by: Tomoyuki Hirose <[email protected]>
Reviewed-by: Daniel Henrique Barboza <[email protected]>
[PMM: reworded commit message]
Reviewed-by: Peter Maydell <[email protected]>
Signed-off-by: Peter Maydell <[email protected]>
Reviewed-by: Nutty Liu <[email protected]>
Thanks,
Nutty
---
hw/riscv/riscv-iommu.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/riscv/riscv-iommu.c b/hw/riscv/riscv-iommu.c
index c3c9ed6469..f0de264a10 100644
--- a/hw/riscv/riscv-iommu.c
+++ b/hw/riscv/riscv-iommu.c
@@ -2433,7 +2433,6 @@ static const MemoryRegionOps riscv_iommu_trap_ops = {
.impl = {
.min_access_size = 4,
.max_access_size = 8,
- .unaligned = true,
},
.valid = {
.min_access_size = 4,
