Re: [PATCH v4 1/9] qtest/phb4: Add testbench for PHB4

[Aditya Gupta]

On 09/05/26 20:03, Aditya Gupta wrote:

On 26/03/05 12:09AM, Saif Abrar wrote:

<...snip...>

+#define PHB3_PBCQ_SPCI_ASB_ADDR      0x0
+#define PHB3_PBCQ_SPCI_ASB_DATA      0x2
+
+/* Index of PNV_CHIP_POWER10 in pnv_chips[] within "pnv-xscom.h" */
+#define PNV_P10_CHIP_INDEX      3

nit: this is unused as of this patch.

rest looks good to me. i had comment about using p11, but noticed none
of the qtest having it, maybe that can be done separately.

Thanks,
- Aditya G

Cc: +harsh +jishnu