Stefan Weil <s...@weilnetz.de> wrote: > Am 28.06.2012 21:21, schrieb Juan Quintela: >> This would make easier to add more operations in the next patches. >> >> Signed-off-by: Juan Quintela <quint...@redhat.com> >> --- >> savevm.c | 54 +++++++++++++++++++++++++----------------------------- >> vmstate.h | 7 +++++++ >> 2 files changed, 32 insertions(+), 29 deletions(-) >> > > > Hi Juan,
Hi stefan > > this mail and the other mails from this patch series trigger > an alert in my mail filter: Just before we start, I just hate email (TM) :-(. > X-Amavis-Alert: BAD HEADER SECTION Duplicate header field: "References" I am looking, at the patches generated by "gfpm" alias just have one of each. Looking into my INBOX. You are right, I also have duplicate In-Reply-To and Reference fields. No clue if the problem is with git or mailer. If it makes any difference, this is git: (trasno *)$ rpm -qa git git-1.7.10.4-1.fc17.x86_64 > The following extract from the mail header shows that there is really > a duplication of the fields "In-Reply-To" and "References": > > From: Juan Quintela <quint...@redhat.com> > To: qemu-devel@nongnu.org > Date: Thu, 28 Jun 2012 21:21:59 +0200 > Message-Id: > <39651e275488caec46861cb5b11ba1c7961a429c.1340910651.git.quint...@redhat.com> > In-Reply-To: <cover.1340910651.git.quint...@redhat.com> > References: <cover.1340910651.git.quint...@redhat.com> > In-Reply-To: <cover.1340910651.git.quint...@redhat.com> > References: <cover.1340910651.git.quint...@redhat.com> > X-Scanned-By: MIMEDefang 2.67 on 10.5.11.12 > X-detected-operating-system: by eggs.gnu.org: Genre and OS details not > recognized. > X-Received-From: 209.132.183.28 > Cc: owass...@redhat.com > Subject: [Qemu-devel] [PATCH 01/12] savevm: Use a struct to pass all > handlers > > This is not a new issue, and there are lots of other mail senders which > also send mails with duplications. I noticed that recently and would like > to understand how it happens. Maybe some tool (git-send-email?) which is > used for sending mails is buggy. > > Do you remember how you created the patch mails? alias gfpm='/usr/bin/git format-patch --signoff --find-renames --thread--cover-letter alias gsend-qemu='/usr/bin/git send-email --smtp-server=smtp.corp.redhat.com --bcc=quint...@redhat.com --from="Juan Quintela <quint...@redhat.com>" --suppress-cc=self --to=qemu-devel@nongnu.org' cd $QEMU_DIR gfpm master -o /tmp/folder/ <edit cover letter until happy> gsend-qemu /tmp/folder/*patch I have always send the emails this way (this is why I have the alias). > Which mailer did you use? Command line, redhat server is zimbra (I think it has postfix underneath, but I would not trust my memory so much). > Do you also see the duplication in your local copy of that mail? As said, the generated file with git-format-patch, only have one header field of each, but the mail that I receive have it duplicated. > Do other users also see the duplicate lines in the full mail header? > > Or is this a bug in my MTA? I also see them, just that I don't get the warning from my mailer. Anyone has any clue? I think that the commands that I use are the "normal" way to send multi-patches series? And what is more, nobody complained in the past. > Regards, Later, Juan.
