On 5/11/2026 9:35 AM, Eric Farman wrote: > Commit 0b83acf2f05 stated: > > Introduce a source set common to system / user. Start it > with the files built in both sets: 'cpu_models_user.c' > and 'gdbstub.c' No logical change intended. > > Except that's not true: > > git show 0b83acf2f0 | grep cpu_models > with the files built in both sets: 'cpu_models_user.c' > + 'cpu_models_user.c', > - 'cpu_models_system.c', > - 'cpu_models_user.c', > > Restore the s390x_user_ss section, move "cpu_models_user.c" back > into it, and re-add "cpu_models_system.c" to the common_system > section. > > Reported-by: Cédric Le Goater <[email protected]> > Fixes: 0b83acf2f05 ("target/s390x: Introduce common system/user meson source > set") > Signed-off-by: Eric Farman <[email protected]> > --- > target/s390x/meson.build | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) >
I ended up rewriting the same patch to answer of Pull Request thread directly :) Reviewed-by: Pierrick Bouvier <[email protected]>
