Please make the following adjustments for future pull requests:

1. Set a public https:// URL for your branch

> are available in the Git repository at:
>
>  [email protected]:gongleiarei/qemu.git tags/cryptodev-2026-05-11

This is not a public URL that I can pull from. You can adjust your .git/config
as follows to use a separate pull request URL and push URL:

  [remote "github"]
        url = https://github.com/gongleiarei/qemu
        pushUrl = [email protected]:gongleiarei/qemu.git

This will allow the scripts that we use for QEMU pull request handling to merge
your pull request without manual steps.

2. Pull requests must be signed with your GPG key

If you don't already have a GPG key, create one and push it to the keyservers.
Then sign your pull request emails. This adds extra protection should someone
manage to spoof your email or compromise your email account. All QEMU pull
requests must be signed.

Two issues with this patch:

1.
>    qemu_mutex_destroy(&lkcf->mutex);
>    qemu_cond_destroy(&lkcf->cond);
>    qemu_mutex_destroy(&lkcf->rsp_mutex);
>
>    for (i = 0; i < MAX_SESSIONS; i++) {
>        if (lkcf->sess[i] != NULL) {
>            cryptodev_lkcf_close_session(backend, i, 0, NULL, NULL);

The mutex is already destroyed, so it is not possible to call
cryptodev_lkcf_close_session() here.

2. cryptodev_lkcf_cleanup() hangs if called right after tasks are queued.
in_use has already been incremented but cryptodev_lkcf_cleanup() frees the
tasks without decrementing in_use. cryptodev_lkcf_close_session() will hang.

Stefan


Reply via email to