From: Peter Xu <[email protected]> Currently qom-list-properties QMP command will crash when querying the portio list MR object. It's because its finalize() assumes full initialization done in portio_list_add_1().
Provide a simple fix for now to avoid the crash. There is chance for a longer term fix, ideally MR should be initialized in instance_init(). However that'll need more work, and that should also be done with cleaning the hard-coded MR operations in portio_list_add_1(). To be explored. Cc: Mark Cave-Ayland <[email protected]> Link: https://lore.kernel.org/r/[email protected] Reported-by: Markus Armbruster <[email protected]> Reviewed-by: Marc-André Lureau <[email protected]> Signed-off-by: Peter Xu <[email protected]> --- system/ioport.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/system/ioport.c b/system/ioport.c index 9209bff2eab..1a0e01fd06b 100644 --- a/system/ioport.c +++ b/system/ioport.c @@ -346,8 +346,15 @@ static void memory_region_portio_list_finalize(Object *obj) { MemoryRegionPortioList *mrpio = MEMORY_REGION_PORTIO_LIST(obj); - object_unref(&mrpio->mr); - g_free(mrpio->ports); + /* + * This check makes sure any random object_new() (without doing the + * rest inits in portio_list_add_1()) will not crash when finalizing. + * One example is QMP command qom-list-properties. + */ + if (mrpio->ports) { + object_unref(&mrpio->mr); + g_free(mrpio->ports); + } } static const TypeInfo memory_region_portio_list_info = { -- 2.54.0
