On 5/11/2026 12:06 PM, Richard Henderson wrote: > Based-on: [email protected] > ("[PATCH v5 0/6] single-binary: deduplicate target_info()") > > Allow TargetInfo accesses to resolve to a direct structure access. > Arrange for the structure to appear const to the majority of qemu. > For user-only, the structure actually is const; for system, the > structure is initialized early. >
It would be nice, if possible, to see those optimizations driven by a concrete benchmark. We had to deal with several premature optimizations along our road on the single-binary, and it would be great to not repeat the same thing again on this new component. > > r~ > > > Richard Henderson (5): > meson: Build target-info-qom.c with -fno-lto > target-info: Expose target_info as const data > target-info: Merge target-info-impl.h into target-info.h > target-info: Merge target-info-qapi.h into target-info.h > target-info: Inline accessors > > include/qemu/target-info-impl.h | 44 ----------- > include/qemu/target-info-init.h | 45 ++++++++--- > include/qemu/target-info-qapi.h | 29 ------- > include/qemu/target-info-qom.h | 2 +- > include/qemu/target-info.h | 123 +++++++++++++++++++++++++++--- > configs/targets/aarch64-softmmu.c | 18 +---- > configs/targets/arm-softmmu.c | 18 +---- > hw/core/machine-qmp-cmds.c | 1 - > hw/uefi/ovmf-log.c | 2 +- > hw/virtio/virtio-mem.c | 2 +- > page-vary-common.c | 10 +-- > page-vary-system.c | 8 +- > system/arch_init.c | 2 +- > target-info-qom.c | 13 ++-- > target-info-stub.c | 27 +------ > target-info.c | 95 ----------------------- > meson.build | 13 ++-- > 17 files changed, 179 insertions(+), 273 deletions(-) > delete mode 100644 include/qemu/target-info-impl.h > delete mode 100644 include/qemu/target-info-qapi.h > delete mode 100644 target-info.c >
