> -----Original Message----- > From: Cédric Le Goater <[email protected]> > Sent: Monday, May 11, 2026 4:17 PM > To: Kane Chen <[email protected]>; Peter Maydell > <[email protected]>; Steven Lee <[email protected]>; Troy > Lee <[email protected]>; Jamin Lin <[email protected]>; Andrew > Jeffery <[email protected]>; Joel Stanley <[email protected]>; open > list:ASPEED BMCs <[email protected]>; open list:All patches CC here > <[email protected]> > Cc: Troy Lee <[email protected]> > Subject: Re: [PATCH v1 1/1] aspeed/hace: Fix mapped address may not be > unmapped issue > > On 5/8/26 07:16, Kane Chen wrote: > > In the do_hash_operation, the code may be returned earlier because > > hash_prepare_sg_iov or hash_prepare_direct_iov may return a failure. > > When this condition is happened, current code flow doesn't go through > > later code segments. Finally, it causes the mapped address isn't > > unmapped properly. > > > > This change is intended to unmap the mapped address if there is any > > error is occurred. Thus, it could prevent a reasoure leak situation. > > May be change that last paragraph to : > > This change unmaps any mapped addresses when an error occurs, > preventing a resource leak. > > The change looks correct. An hack from an HACE-aware engineer would be > appreciated. > > Thanks, > > C. >
Hi Cédric, Thanks for your review and comments. Should I submit a v2 patch to incorporate the requested changes to the commit log? Best Regards, Kane
