On Tue, 12 May 2026 at 17:46, Scott J. Goldman <[email protected]> wrote: > > On Mon Apr 27, 2026 at 3:55 PM EDT, Scott J. Goldman wrote: > > Commit b5f8f77271 ("accel/hvf: Implement WFI without using pselect()") > > changed hvf_wfi() from blocking the vCPU thread with pselect() to > > returning EXCP_HLT, intending QEMU's main event loop to handle the > > idle wait. However, cpu->halted was never set, so cpu_thread_is_idle() > > always returns false and the vCPU thread spins at 100% CPU per core > > while the guest is idle. > > > > Fix this by:
> Hi Peter-- > > Sorry to nag, just was wondering if you could take a look at this follow-up > to your earlier review comments in: > https://lore.kernel.org/qemu-devel/CAFEAcA9RHQ+7++=kLn2goJwcgzDnaqdkQtQBtxQ2Rw1-uiKY=g...@mail.gmail.com/#t > > It's a bit of an unfortunate regression, so I was hoping to get some form of > the fix in. I'm really hoping that somebody who knows and uses hvf will review this (and your other hvf patchset)... -- PMM
