On Fri, 15 May 2026 at 18:07, Cédric Le Goater <[email protected]> wrote: > > A recent change in glibc 2.42.9000 [1] changes the return type of > strstr() and other string functions to be 'const char *' when the > input is a 'const char *'. This breaks the build in : > > ../tests/qtest/libqtest.c: In function ‘qtest_verbose’: > ../tests/qtest/libqtest.c:2175:15: error: assignment discards ‘const’ > qualifier from pointer target type [-Werror=discarded-qualifiers] > 2175 | found = strstr(log, domain); > > Fix this by changing the type of the variable that store the result to > 'const char *'. > > [1] > https://sourceware.org/git/?p=glibc.git;a=commit;h=cd748a63ab1a7ae846175c532a3daab341c62690 > > Fixes: f606321be88c ("tests/qtest: Individual verbose switches") > Signed-off-by: Cédric Le Goater <[email protected]> > --- > tests/qtest/libqtest.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/qtest/libqtest.c b/tests/qtest/libqtest.c > index bf9284b9a131..b1e06ea364ec 100644 > --- a/tests/qtest/libqtest.c > +++ b/tests/qtest/libqtest.c > @@ -2146,7 +2146,7 @@ bool mkimg(const char *file, const char *fmt, unsigned > size_mb) > bool qtest_verbose(const char *domain) > { > const char *log = getenv("QTEST_LOG"); > - char *found; > + const char *found; > > assert(domain);
Same fix posted slightly earlier: https://lore.kernel.org/qemu-devel/[email protected]/ thanks -- PMM
