On Sun, May 10, 2026 at 08:03:53AM -0500, Corey Minyard wrote: > On Thu, May 07, 2026 at 10:05:18PM +1000, Nicholas Piggin wrote: > > Hi, > > > > This series contains the DW I2C model written by Chris Rauer and > > updated for the Tenstorrent Atlantis machine recently. There was > > some more review comment on that submission and so we decided to > > take the I2C device out of that series and work on it separately, > > see here: > > > > https://lore.kernel.org/qemu-devel/[email protected]/T/#mb1ef2824c2f1f37bf4574dc1ef0fb95566c3a2f2 > > > > The big thing suggested was to move to the QEMU register API. That > > is a big change and difficult to review, so I have split that and > > a some smaller changes out into their own patches. I don't expect > > detailed reviews on the register API patch -- it's quite mechanical > > and I did attempt to verify it by diff'ing register traces. But it > > would be good to make sure maintainers are happy to go that way. > > > > Unfortunately the patch 1 was quite well reviewed and tested so > > incremental changes would be preferable, but it is painful to maintain > > migration compatibility across these changes. > > I had a few comments on the first patch, but they were all fixed in > later patches. From my review this all looks good. > > Yes, please squash these as you suggested in the second patch. > > Acked-by: Corey Minyard <[email protected]>
Thank you for the Ack, Corey. Since everybody is happier with it now I will squash and submit it with the next revision of the tt-atlantis series. Thanks, Nick
