On Fri, Jun 29, 2012 at 9:13 AM, Andreas Färber <afaer...@suse.de> wrote: > Please run scripts/checkpatch.pl for CODING_STYLE issues, I spotted one > slightly misplaced if brace, and one empty line at the bottom seemed to > have indentation (git-am complains about that, too). Done. The only issue left is a false positive:
ERROR: "foo * bar" should be "foo *bar" #248: FILE: fpu/softfloat.h:507: +int floatx80_remainder(floatx80, floatx80, floatx80 *, uint64_t * STATUS_PARAM); (STATUS_PARAM is not the name of the param, it's a macro.) > The patch description will need to be cleaned up (not be letter-style). Done. > I'm not too thrilled to introduce more uses of int32 (we started > converting int16 to int_fast16_t) but I won't veto. It would be nice if > you could review for any potential int32 vs. int32_t breakages though, > to not make things worse than they are. I did notice one place where int32 was used where int should be used (the return variable of do_fprem), and that's now fixed. But for the other uses of int32, as I was saying to Peter, they are tied to the return type of extractFloatx80Exp. I wouldn't give the variable a different type than the function, and especially not in this case because the function should become int16_t, not int32_t. I'll be sending a PATCHv2 momentarily.