Bin Guo <[email protected]> writes: > Drop the unnecessary strcpy of an empty literal (and its spurious > (char *)& cast) in favor of a direct NUL store, which avoids the > libc call and hides no bugs behind a cast. > > Signed-off-by: Bin Guo <[email protected]> > --- > migration/global_state.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/migration/global_state.c b/migration/global_state.c > index c1f90fce0f..91fefdf525 100644 > --- a/migration/global_state.c > +++ b/migration/global_state.c > @@ -148,7 +148,7 @@ static const VMStateDescription vmstate_globalstate = { > void register_global_state(void) > { > /* We would use it independently that we receive it */ > - strcpy((char *)&global_state.runstate, ""); > + global_state.runstate[0] = '\0'; > global_state.received = false; > vmstate_register(NULL, 0, &vmstate_globalstate, &global_state); > }
Reviewed-by: Fabiano Rosas <[email protected]>
