Hi Pierrick, Cedric,
On 13/05/26 9:46 PM, Pierrick Bouvier wrote:
On 5/12/2026 12:54 AM, Cédric Le Goater wrote:
+ Pierrick, Philippe
On 5/12/26 09:11, Narayana Murty N wrote:
The file spapr_pci_vfio.c contains exclusively EEH (Enhanced Error
Handling) related functions for VFIO devices on sPAPR platforms.
To better reflect its specific purpose and improve code organization,
this commit:
1. Renames spapr_pci_vfio.c to spapr_pci_vfio_eeh.c
2. Moves spapr_phb_vfio_eeh_reenable() from spapr_pci_vfio_eeh.c to
spapr_pci.c, as it's a general PHB operation not specific to
VFIO EEH error injection/recovery
After this change, spapr_pci_vfio_eeh.c contains only the core VFIO
EEH error handling functions, making the file's purpose more focused
and clear.
This is a refactoring change with no functional impact.
Signed-off-by: Narayana Murty N <[email protected]>
---
hw/ppc/Kconfig | 2 +-
hw/ppc/meson.build | 2 +-
hw/ppc/spapr_pci.c | 14 ++++++++++++++
hw/ppc/{spapr_pci_vfio.c => spapr_pci_vfio_eeh.c} | 12 +-----------
There is a CONFIG_VFIO_PCI in this file that could be replaced
with stub definitions.
Indeed, we didn't touch this yet because it hw/ppc, and it's not in the
list of target where we are focused.
Indeed, the #include CONFIG_DEVICES and #ifdef CONFIG_VFIO_PCI can be
removed, and stubs for spapr_phb_* functions be added in a new
spapr_pci_vfio-stubs.c file, and added to stub_ss.
Thanks for your suggestions. I have incorporated above suggestions in v2
here:
https://lore.kernel.org/all/[email protected]/
Please take a look and let me know if any further review comments.
Thanks
Narayana Murty
Regards,
Pierrick
