The viommu field is assigned but never used. Callers freeing the veventq already have access to the IOMMUFDViommu object through other references, so this field is redundant.
Removing it also simplifies upcoming changes where veventq is allocated based on the viommu id before the IOMMUFDViommu object is created (e.g. vendor CMDQV-based veventq allocation). No functional change. Reviewed-by: Nicolin Chen <[email protected]> Reviewed-by: Eric Auger <[email protected]> Signed-off-by: Shameer Kolothum <[email protected]> --- include/system/iommufd.h | 1 - hw/arm/smmuv3-accel.c | 1 - 2 files changed, 2 deletions(-) diff --git a/include/system/iommufd.h b/include/system/iommufd.h index bb8d5081d7..da68ba0037 100644 --- a/include/system/iommufd.h +++ b/include/system/iommufd.h @@ -58,7 +58,6 @@ typedef struct IOMMUFDVdev { /* Virtual event queue interface for a vIOMMU */ typedef struct IOMMUFDVeventq { - IOMMUFDViommu *viommu; uint32_t veventq_id; uint32_t veventq_fd; uint32_t last_event_seq; /* Sequence number of last processed event */ diff --git a/hw/arm/smmuv3-accel.c b/hw/arm/smmuv3-accel.c index bfa6a03f9e..30c498ffcf 100644 --- a/hw/arm/smmuv3-accel.c +++ b/hw/arm/smmuv3-accel.c @@ -553,7 +553,6 @@ bool smmuv3_accel_alloc_veventq(SMMUv3State *s, Error **errp) veventq = g_new0(IOMMUFDVeventq, 1); veventq->veventq_id = veventq_id; veventq->veventq_fd = veventq_fd; - veventq->viommu = accel->viommu; accel->veventq = veventq; /* Set up event handler for veventq fd */ -- 2.43.0
