On Tue, May 19, 2026 at 9:05 AM Pierrick Bouvier <
[email protected]> wrote:

> On 5/18/2026 4:27 PM, Warner Losh wrote:
> > Replace 'void *cpu_env' parameters with 'CPUArchState *env' across all
> > bsd-user source files. This improves type safety and aligns with the
> > convention used in the rest of the codebase.
> >
> > Signed-off-by: Stacey Son <[email protected]>
> > Signed-off-by: Warner Losh <[email protected]>
> > Assisted-by: Claude Opus 4.6 (1M context)
> > ---
> >  bsd-user/aarch64/target.h     |  2 +-
> >  bsd-user/arm/target.h         |  2 +-
> >  bsd-user/bsd-file.h           | 28 +++++++++++++--------------
> >  bsd-user/bsd-mem.h            |  4 ++--
> >  bsd-user/bsd-proc.h           |  6 +++---
> >  bsd-user/freebsd/os-proc.c    |  4 ++--
> >  bsd-user/freebsd/os-proc.h    | 26 ++++++++++++-------------
> >  bsd-user/freebsd/os-sys.c     |  4 ++--
> >  bsd-user/freebsd/os-syscall.c | 44
> +++++++++++++++++++++----------------------
> >  bsd-user/i386/target.h        |  2 +-
> >  bsd-user/qemu.h               |  6 +++---
> >  bsd-user/riscv/target.h       |  2 +-
> >  bsd-user/x86_64/target.h      |  2 +-
> >  13 files changed, 66 insertions(+), 66 deletions(-)
> >
>
> ...
>
> > diff --git a/bsd-user/bsd-proc.h b/bsd-user/bsd-proc.h
> > index b1d4446ff1..62052c70b9 100644
> > --- a/bsd-user/bsd-proc.h
> > +++ b/bsd-user/bsd-proc.h
> > @@ -6,8 +6,8 @@
> >   * SPDX-License-Identifier: GPL-2.0-or-later
> >   */
> >
> > -#ifndef BSD_PROC_H_
> > -#define BSD_PROC_H_
> > +#ifndef BSD_PROC_H
> > +#define BSD_PROC_H
> >
>
> Last patch of the series does the opposite change in comment associated
> to endif. We should pick one and stick to it consistently.
>

Ugg. OK. Good eye, I'll see if there's some good standard here. I hit a lot
of conflicts a while
back when the tree was normalized, so I'll make sure I just do that.

Warner

Reply via email to