On 07/03/2012 03:32 PM, Eric Blake wrote:
>> + ret = uleb128_decode_small(src + i, &count);
>> + if (ret < 0) {
>
> An nzrun should be a non-zero value; I'd write this as (ret <= 0) to
> rule out an attempt to pass a zero-length nzrun.
Correcting myself,
if (ret < 0 || !count) {
At this point, I think I will just bite the bullet and post a version of
this code that incorporates my review.
--
Eric Blake ebl...@redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
