On 5/19/2026 11:11 PM, Peter Xu wrote:
External email: Use caution opening links or attachments
On Tue, May 05, 2026 at 11:14:23AM +0300, Avihai Horon wrote:
Now that VFIO has implemented new switchover-ack, enable it.
Signed-off-by: Avihai Horon <[email protected]>
---
migration/options.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/migration/options.c b/migration/options.c
index 44327c588f..91571f9d30 100644
--- a/migration/options.c
+++ b/migration/options.c
@@ -108,9 +108,8 @@ const Property migration_properties[] = {
preempt_pre_7_2, false),
DEFINE_PROP_BOOL("multifd-clean-tls-termination", MigrationState,
multifd_clean_tls_termination, true),
- /* Use legacy until VFIO implements new switchover-ack */
Removing this line is fine because it's a very temporary thing. But maybe
it would be good we have some rich documentation on both the legacy and new
behavior of switchover-ack. Normally it would be qapi/migration.json, but
in this case the user shouldn't need to choose, so I think when keeping
qapi doc simple we need to have somewhere internal that document all these.
Sure, I can do that.
Would adding it as a comment above struct
MigrationState->switchover_ack_legacy be fine?
Thanks.
DEFINE_PROP_BOOL("switchover-ack-legacy", MigrationState,
- switchover_ack_legacy, true),
+ switchover_ack_legacy, false),
/* Migration parameters */
DEFINE_PROP_UINT8("x-throttle-trigger-threshold", MigrationState,
--
2.40.1
--
Peter Xu
