On 07/03/2012 11:15 PM, Shrinidhi Joshi wrote: > On Saturday 16 June 2012 03:41 AM, Eric Blake wrote: >> On 06/15/2012 02:48 PM, Supriya Kannery wrote: >> > raw-posix driver changes for bdrv_reopen_xx functions to >> > safely reopen image files. Reopening of image files while >> > changing hostcache dynamically is handled here. >> >
> raw-posix driver changes for bdrv_reopen_xx functions to > safely reopen image files. Reopening of image files while > changing hostcache dynamically is handled here. A resubmission of a fixed patch is better handled as a new thread with a v2 in the subject line, rather than embedded as a reply to the v1 comments. > + raw_stash_state(raw_rs->stash_s, s); > + s->fd = dup3(raw_rs->stash_s->fd,s->fd,O_CLOEXEC); > + dup3() is not universally available (it is not in POSIX, yet). You need configure checks to determine if it exists, and a graceful fallback using dup2()/fcntl(F_GETFD/F_SETFD) if not. -- Eric Blake ebl...@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
