> >> I think this check should be at the top of the loop. If the bit is set, > >> simply return with that warning message. No further processing is needed. > > > > IIUC, in this way we would always skip optional parameter, right? My idea > > is to > > always process optional parameters if we support it. > > The spec says: > > "The top bit of this type may be set to indicate a loader may safely ignore > that structure.” > > So if the bit is set, the way I understand it, there is no need for further > processing.
I read that as "If that directive is unsupported (by the hypervisor) it safe to skip it (instead of throwing an fatal error)", so In think the patch is correct in looking at the flag in the error handling code path. Never processing the directive also doesn't make much sense, why would one write such a directive into the igvm file in the first place? take care, Gerd
