Re: [PATCH v4 1/9] hw/arm/smmuv3: Update ATC invalidation check

[Eric Auger]

On 5/28/26 12:16 AM, Nathan Chen wrote:
> From: Nathan Chen <nath...@nvidia.com>
>
> Use smmuv3_ats_enabled() to determine whether ATS is enabled for the
> guest when handling an ATC invalidation command, as setting the ATS
> property value to 'auto' will resolve to ATS being detected as
> enabled in the ATC invalidation check otherwise.
>
> Fixes: f7f5013a55a3 ("hw/arm/smmuv3-accel: Add support for ATS")
> Suggested-by: Shameer Kolothum <skolothum...@nvidia.com>
nit: Reported-by whould have been more suited
> Signed-off-by: Nathan Chen <nath...@nvidia.com>
> ---
>  hw/arm/smmuv3.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/arm/smmuv3.c b/hw/arm/smmuv3.c
> index 5c2855c377..0c65dc8c91 100644
> --- a/hw/arm/smmuv3.c
> +++ b/hw/arm/smmuv3.c
> @@ -1528,7 +1528,7 @@ static int smmuv3_cmdq_consume(SMMUv3State *s, Error 
> **errp)
>          {
>              SMMUDevice *sdev = smmu_find_sdev(bs, CMD_SID(&cmd));
>  
> -            if (!sdev || !s->ats) {
> +            if (!sdev || !smmuv3_ats_enabled(s)) {
>                  trace_smmuv3_unhandled_cmd(type);
>                  break;
>              }
Reviewed-by: Eric Auger <eric.au...@redhat.com>

Eric