On Thu, 28 May 2026 at 14:09, Xiang W <[email protected]> wrote: > > According to the ACPI Serial Port Console Redirection Table (SPCR) > specification, the field order after Flow Control is: > > - Terminal Type (offset 62, 1 byte) > - Language (offset 63, 1 byte) > > Previously they were swapped in both: > - The table generation code (aml-build.c) > - The golden reference blobs > > This fixes: > - hw/acpi/aml-build.c > - tests/data/acpi/riscv64/virt/SPCR > - tests/data/acpi/loongarch64/virt/SPCR > > Reference: > https://learn.microsoft.com/en-us/windows-hardware/drivers/bringup/serial-port-console-redirection-table > > Signed-off-by: Xiang W <[email protected]> > --- > hw/acpi/aml-build.c | 4 ++-- > tests/data/acpi/loongarch64/virt/SPCR | Bin 80 -> 80 bytes > tests/data/acpi/riscv64/virt/SPCR | Bin 90 -> 90 bytes > 3 files changed, 2 insertions(+), 2 deletions(-)
The comment at the top of tests/qtest/bios-tables-test.c describes how to structure changes that affect the ACPI tables. You should have a multi-patch series that first disables the affected tests, then makes the changes, and finally updates the golden reference blobs, not a single patch that changes code and test blobs at once. thanks -- PMM
