On Mon, 18 May 2026 at 08:34, Corvin Köhne <[email protected]> wrote:
>
> From: YannickV <[email protected]>
>
> This commit offers some documentation on the Beckhoff CX7200
> qemu emulation.
>
> Signed-off-by: YannickV <[email protected]>
> Reviewed-by: Alex Bennée <[email protected]>
> ---
>  docs/system/arm/beckhoff-cx7200.rst | 62 +++++++++++++++++++++++++++++
>  docs/system/target-arm.rst          |  1 +
>  2 files changed, 63 insertions(+)
>  create mode 100644 docs/system/arm/beckhoff-cx7200.rst
>
> diff --git a/docs/system/arm/beckhoff-cx7200.rst 
> b/docs/system/arm/beckhoff-cx7200.rst
> new file mode 100644
> index 0000000000..6163a0cfa5
> --- /dev/null
> +++ b/docs/system/arm/beckhoff-cx7200.rst
> @@ -0,0 +1,62 @@

Checkpatch will complain about the lack of an SPDX tag here.
For documentation, the syntax to put this in a comment is to
start the line with ".. ", like this:

.. SPDX-License-Identifier: GPL-2.0-or-later

> +Beckhoff CX7200 (``beckhoff-cx7200``)
> +======================================

One "=" too many. The title underlining needs to match the title string
(some Sphinx versions will complain about this, but not all).

> +The Beckhoff CX7200 is based on the same architecture as the Xilinx Zynq A9.
> +The Zynq 7000 family is based on the AMD SoC architecture. These products
> +integrate a feature-rich dual or single-core Arm Cortex-A9 MPCore based
> +processing system (PS) and AMD programmable logic (PL) in a single device.
> +The Beckhoff Communication Controller (CCAT) can be found in the PL of Zynq.
> +
> +You can find more detail about this board on
> +`the manufacturer's product page 
> <https://www.beckhoff.com/en-en/products/ipc/embedded-pcs/cx7000-arm-r-cortex-r/cx7293.html?>`__.
> +The SoC is documented in the
> +`Zynq 7000 Technical Reference manual 
> <https://docs.amd.com/r/en-US/ug585-zynq-7000-SoC-TRM>`__.
> +
> +The CX7200 supports the following:
> +
> +- Arm Cortex-A9 MPCore CPU
> +
> +  - Cortex-A9 CPUs
> +  - GIC v1 interrupt controller
> +  - Generic timer
> +  - Watchdog timer
> +
> +- OCM 256KB
> +- SMC SRAM 64MB
> +- Zynq SLCR
> +- SPI x2
> +- QSPI
> +- UART
> +- TTC x2
> +- Gigabit Ethernet Controller x2
> +- SD Controller x2
> +- XADC
> +- Arm PrimeCell DMA Controller
> +- DDR Memory
> +- USB 2.0 x2
> +- DDR Controller
> +- Beckhoff Communication Controller (CCAT)
> +
> +  - EEPROM Interface
> +  - DMA Controller

Just to check, are these indented because they're
sub-features of the CCAT ?

> +
> +The following is not supported:
> +    - I2C

You need to have this with the bullet point not indented, and with a
newline in front of it:

The following is not supported:

- I2C

Otherwise it will be interpreted as an RST definition list, and
rendered oddly.

> +Directly loading an ELF file to the CPU of the CX7200 to run f.e. TC/RTOS 
> (based on FreeRTOS):

I would drop "f.e." which is a slightly nonstandard abbreviation.

Also this line is a bit overlong -- generally worth breaking
lines at about 70-75 chars.

Otherwise
Reviewed-by: Peter Maydell <[email protected]>

thanks
-- PMM

Reply via email to