Re: [PATCH] disas: sparc: Fix integer overflow in compare_opcodes() for loop

[Richard Henderson]

On 5/28/26 02:17, Peter Maydell wrote:

@@ -2525,7 +2526,7 @@ compare_opcodes (const void * a, const void * b)

    for (i = 0; i < 32; ++i)
      {
-      unsigned long int x = 1 << i;
+      unsigned long int x = BIT(i);
        int x0 = (lose0 & x) != 0;
        int x1 = (lose1 & x) != 0;

If we're going to bother to change this not-a-bug, it would
be  better to do it the way that upstream binutils did it,
as noted in the gitlab issue: using "1ul".

I would go further and use uint32_t not unsigned long at all.
If we're going to change anything.

r~