Thanks to Titus, Jonathan and Cedric for reviewing

Summary of changes from v4:

machine:
- no changes

functional test:
- add missing import: from qemu_test import wait_for_console_pattern

max31790:
- add trailing newline to log messages
- fix a couple of formatting issues
- log a guest error if max31790_recv detects over-read
- fix Kconfig (depends on I2C) instead of PMBUS
- remove an unused import from functional test
- rename 'rpm' array to 'tach_count' to better reflect its actual purpose
- fix functional test with correct RPM value and additional checks to test for

  pwm1 <= pwm2 => rpm(pwm1) <= rpm(pwm2)

  I must have had some misconception about what's stored in tach_count and how 
it
  relates to rpm, hope that's cleared up now in the code.

max11615:
- fix comment style in header
- remove #include <stdint.h>
- max11615_write_config_byte: fix comment (MAX11615 is only 8 channels)
- fix possible out of bounds access missed by max11615_write_config_byte
- remove an empty function
- max11615_init_with_values: simplify (directly applied the suggested code 
snippet)
- max11615_reset: reset channel readings as well.
- init_with_values uses decimals now instead of binary notation
- support differential mode
- support unipolar / bipolar mode
- max11615_write_config_byte: log unimplemented for scan mode != 0b11
- max11615_write_setup_byte: log unimplemented for external reference set
- max11615_recv: support multichannel scans
- functional test is using stable file name (bus + address + wildcard)

adc128d818:
- fix comment style in header
- replace #include <stdint.h> with #include <qemu/osdep.h>
- adc128d818_write_advanced_config: reset channel readings and interrupt status
- adc128d818_send: check s->len before writing into s->buf[s->len]
- adc128d818_init: remove (empty function)
- adc128d818_init_with_values: simplify channel init similar to max11615
- adc128d818_reset: reset channel readings

Alexander Hansen (5):
  ast2600: yosemite4 initial support
  ast2600: yosemite4 functional test
  hw/sensor: MAX31790 support
  hw/sensor: support MAX11615
  hw/sensor: support Texas Instruments ADC128D818

 MAINTAINERS                              |   3 +
 include/hw/sensor/adc128d818.h           |  23 +
 include/hw/sensor/max11615.h             |  20 +
 hw/arm/aspeed_ast2600_fby4.c             | 280 ++++++++++++
 hw/sensor/adc128d818.c                   | 433 ++++++++++++++++++
 hw/sensor/max11615.c                     | 312 +++++++++++++
 hw/sensor/max31790.c                     | 537 +++++++++++++++++++++++
 hw/arm/Kconfig                           |   3 +
 hw/arm/meson.build                       |   1 +
 hw/sensor/Kconfig                        |  12 +
 hw/sensor/meson.build                    |   3 +
 hw/sensor/trace-events                   |  26 ++
 tests/functional/arm/meson.build         |   2 +
 tests/functional/arm/test_aspeed_fby4.py |  89 ++++
 14 files changed, 1744 insertions(+)
 create mode 100644 include/hw/sensor/adc128d818.h
 create mode 100644 include/hw/sensor/max11615.h
 create mode 100644 hw/arm/aspeed_ast2600_fby4.c
 create mode 100644 hw/sensor/adc128d818.c
 create mode 100644 hw/sensor/max11615.c
 create mode 100644 hw/sensor/max31790.c
 create mode 100755 tests/functional/arm/test_aspeed_fby4.py

Cc: Titus Rwantare <[email protected]>
Cc: "Cédric Le Goater" <[email protected]> (maintainer:ASPEED BMCs)
Cc: Jonathan Cameron <[email protected]>

-- 
2.54.0


Reply via email to