On Thu, Jul 05, 2012 at 12:51:12AM +0200, Andreas Färber wrote: > Am 04.07.2012 23:20, schrieb Michael S. Tsirkin: > > On Wed, Jul 04, 2012 at 07:19:20PM +0200, Andreas Färber wrote: > >> Also give the sPAPR host bridge type registration functions a unique > >> name. > >> > >> Signed-off-by: Andreas Färber <afaer...@suse.de> > > > > I'd like to note that this is a bad practice. > > Yoy write one thing in the 1 line summary > > and then in the full commit log you > > write about other unrelated stuff. > > (It seemed related by the proximity to the TypeInfo fwiw.) > > > Make it a separate patch. > > Do you request that for Coding Style fixes, too? See QOM'ify prep_pci > for an example that removed the only remaining violations in the file > while touching code above and below. > > Background of why v2 already did multiple things at once (without anyone > complaining) was that Anthony complained that my CPU refactorings were > too long and not doing enough in one patch. > > I'm already up from 2 to 14 here and don't mind splitting things up > further again but I don't think there's sufficient reason that warrants > having a patch that just renames the function for aesthetics. Would you > be okay with moving it into the corresponding QOM'ify sPAPR patch or the > final "Tidy up" patch instead? > > Andreas
You can even leave it as is, but subject should then say 'misc cleanups in XXXX.c' ot something to that effect. > -- > SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany > GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg >