On Thu, May 21 2026, Farhan Ali <[email protected]> wrote: > Remove the FH_MASK_ENABLE check when disabling interrupt forwarding > during device reset. This check was broken for the default case in > the switch statement above, preventing proper cleanup of interrupt > forwarding. > > The pbdev->aif check in s390_pci_kvm_aif_disable() already guards > against double-disabling of interrupt forwarding. > > Cc: [email protected] > Reported-by: Niklas Schnelle <[email protected]> > Signed-off-by: Farhan Ali <[email protected]> > --- > hw/s390x/s390-pci-bus.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/s390x/s390-pci-bus.c b/hw/s390x/s390-pci-bus.c > index 3665aba106..2f7b214891 100644 > --- a/hw/s390x/s390-pci-bus.c > +++ b/hw/s390x/s390-pci-bus.c > @@ -1542,7 +1542,7 @@ static void s390_pci_device_reset(DeviceState *dev) > break; > } > > - if (pbdev->interp && (pbdev->fh & FH_MASK_ENABLE)) { > + if (pbdev->interp) { > /* Interpreted devices were using interrupt forwarding */ > s390_pci_kvm_aif_disable(pbdev); > } else if (pbdev->summary_ind) {
Thanks, queued to s390-next.
