On 29/5/26 21:03, Mohamed Mediouni wrote:
On 29. May 2026, at 16:24, Philippe Mathieu-Daudé <[email protected]> wrote:
Register the new AccelOpsClass::cpu_instance_init hook.
ACCEL_CPU_NAME("whpx") TypeInfo is now empty, remove it.
Signed-off-by: Philippe Mathieu-Daudé <[email protected]>
---
accel/whpx/whpx-accel-ops.c | 2 ++
accel/whpx/whpx-common.c | 17 -----------------
target/arm/whpx/whpx-all.c | 1 -
target/i386/whpx/whpx-all.c | 1 -
4 files changed, 2 insertions(+), 19 deletions(-)
diff --git a/accel/whpx/whpx-accel-ops.c b/accel/whpx/whpx-accel-ops.c
index b8f41544cbe..099e8ef6da3 100644
--- a/accel/whpx/whpx-accel-ops.c
+++ b/accel/whpx/whpx-accel-ops.c
@@ -98,6 +98,8 @@ static void whpx_accel_ops_class_init(ObjectClass *oc, const
void *data)
ops->handle_interrupt = generic_handle_interrupt;
ops->supports_guest_debug = whpx_supports_guest_debug;
+ ops->cpu_instance_init = whpx_cpu_instance_init;
+
Hi,
No whpx_cpu_instance_init implementation present in the commit
as far as I can tell.
You exposed it in commit 4610fee3242 ("whpx: reshuffle common code") :)
Did you miss it? Other than that things look fine and a stub implementation
should be okay.
ops->synchronize_post_reset = whpx_cpu_synchronize_post_reset;
ops->synchronize_post_init = whpx_cpu_synchronize_post_init;
ops->synchronize_state = whpx_cpu_synchronize_state;
