On Wed, Jun 03, 2026 at 02:51:30PM -0300, Fabiano Rosas wrote: > Daniel P. Berrangé <[email protected]> writes: > > > In that case they should definitely be independent command line > > options. The old "-incoming" design is already broken / limited > > in the non-'defer' case because it is hardcoded to use URI syntax > > which can't express all the address formats we accept in QAPI > > syntax. Adding more special cases onto -incoming just makes the > > bad situation even worse and is not a forward looking design. > > > > If we need the ability to specify migration parameters on the > > CLI, then as a starting point for the design, we should assume that > > -incoming does not exist, and design a complete solution from scratch > > that uses QAPI exclusively, both for addresses and configuration. > > > > As discussed before, IMHO the "migrate" and "migrate-incoming" > > commands need to accept both the address(s) and parameters/capabilities > > as inline data items rather than relying on pre-configured global state > > from the 'migrate-parameter' / 'migrate-capability' commands. > > > > If we did that modelling for 'migrate-incoming' then that modelling of > > command parmaeters could map directly to a new '-migrate-incoming' > > command line argument that accepted exactly the same data model. > > > > Maybe a user creatable object would better fit this use case instead of > a new command. We could expose what is today MigrationParameters plus > the few compat options from migration_properties. It could work more or > less the same for the QMP migration commands, QMP set/get commands, > source and destination command lines, the compatibility use-case and the > debugging use-case.
If we can do something using "-object" that is useful both at command line time and in QMP runtime, then that would be interesting too. My general feeling wrt changes to the current command line is that any suggestion should be desgined with a nod towards a future scenario where QEMU is 100% configured with QMP. ie the full command line is qemu-system-x86_64 -qmp <address> In this world, the current -incoming argument is already largely unsatisfactory for anything other than "defer". A model that uses -object would fit in well, as would a hypothetical -migrate-incoming that directly mapped to 'migrate-incoming' QMP including capabilities and parameters. With regards, Daniel -- |: https://berrange.com ~~ https://hachyderm.io/@berrange :| |: https://libvirt.org ~~ https://entangle-photo.org :| |: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|
