Am 05.07.2012 18:39, schrieb Markus Armbruster: > Markus Armbruster <arm...@redhat.com> writes: > >> Kevin Wolf <kw...@redhat.com> writes: >> >>> Am 29.06.2012 17:34, schrieb Markus Armbruster: >>>> New limits straight from ATA4 6.2 Register delivered data transfer >>>> command sector addressing. >>>> >>>> I figure the old sector limit 63 was blindly copied from the BIOS >>>> int 13 limit. Doesn't apply to the hardware. No idea where the old >>>> cylinder limit comes from. >>>> >>>> Signed-off-by: Markus Armbruster <arm...@redhat.com> >>> >>> Now I think we have the very same thing in IDE, SCSI and virtio-blk. >>> Would it make sense to have a helper function in hd-geometry.c that >>> takes and validates the geometry from a BlockConf, applies defaults and >>> puts the result into device state fields passed by reference? >> >> I can look into this, but I'm afraid we'd need two helpers, because of >> IDE complications. > > I'd like to try this in a follow-up series, together with a few more > cleanups made possible by this series. Okay?
Fine with me. Kevin
