On 1/14/2026 1:46 AM, Nicholas Piggin wrote:
icount triggers are supported so tinfo should advertise them.

Signed-off-by: Nicholas Piggin <[email protected]>
---
  target/riscv/debug.c | 2 ++
  1 file changed, 2 insertions(+)

diff --git a/target/riscv/debug.c b/target/riscv/debug.c
index 69e7037fac..605ed95b14 100644
--- a/target/riscv/debug.c
+++ b/target/riscv/debug.c
@@ -865,7 +865,9 @@ void tdata_csr_write(CPURISCVState *env, int tdata_index, 
target_ulong val)
  target_ulong tinfo_csr_read(CPURISCVState *env)
  {
      /* assume all triggers support the same types of triggers */
+    /* XXX: should we set 1 (version 1.0) in the version field? */

For the 'debug' flag, no.  For sdtrig and others, yes.

      return BIT(TRIGGER_TYPE_AD_MATCH) |
+           BIT(TRIGGER_TYPE_INST_CNT) |
             BIT(TRIGGER_TYPE_AD_MATCH6);
  }

Reviewed-by: Daniel Henrique Barboza <[email protected]>



Reply via email to