On Thu, 4 Jun 2026 at 11:11, Akihiko Odaki <[email protected]> wrote:
>
> Check more text files: Objective-C, Meson, "hx", JSON, and property
> list.
>
> Signed-off-by: Akihiko Odaki <[email protected]>
This is missing rationale. Currently checkpatch is set up
to check source code files, and the bulk of its checks are
for source code issues. Why do we want to make it also check
non-source-code files?
> -our $SrcFile = qr{\.(?:(h|c)(\.inc)?|cpp|s|S|pl|py|sh)$};
> +our $SrcFile =
> +
> qr{\.(?:(h|c|m)(\.inc)?|cpp|s|S|pl|py|sh|build|hx|in|json|plist|txt)$};
If I run checkpatch on our .hx files, I get a lot of complaints
about trailing whitespace after "\" characters. I have a vague
memory that those are deliberate, though I forget the details.
We shouldn't add a file type to this list if it's going to
produce a lot of false positives.
thanks
-- PMM
